fix(core): align DecorrelationMeter to the autocorrelation-corrected margin (Caveat-A) - #10028
Merged
AceHack merged 1 commit intoAug 4, 2026
Conversation
…margin (Caveat-A) DecorrelationMeter.classifyPair / fuse now bound at 2 + AntiSybil.chshMarginAutocorr (the pair's own HAC effective-sample margin) instead of the i.i.d. chshMargin, matching the chshSybilCalibrated default switch (#10027). An autocorrelated / periodic probe stream no longer under-states the fluctuation, so it needs more rounds to convict AboveClassicalBound — the correct, more-conservative behavior. Resolves the module's own SOUNDNESS-block autocorrelation caveat (updated). Same subset logic as the anti-sybil switch: margin_corrected ≥ margin_iid ⇒ can only remove false AboveClassicalBound verdicts, never add. Streams are already in hand at both call sites (no signature change). The i.i.d. chshMargin stays exported for callers who explicitly want it. 8 DecorrelationMeter tests green with NO fixture changes (the s4 fixtures' autocorrelation is mild enough that |S|=4 still clears the corrected bound at n=100; the tiny-n non-conviction and identical-pair tests hold a fortiori). Core 0-warning. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
AceHack
deleted the
fix/decorrelationmeter-align-to-corrected-margin-20260804
branch
August 4, 2026 15:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the
DecorrelationMeter(the earlier scope-limited CHSH instrument) with thechshSybilCalibrateddefault switch (#10027):classifyPair/fusenow bound at2 + AntiSybil.chshMarginAutocorr(the pairs own HAC effective-sample margin) instead of the i.i.d.chshMargin.Effect
An autocorrelated / periodic probe stream no longer under-states the fluctuation, so it needs more rounds to convict
AboveClassicalBound— the correct, more-conservative behavior. Resolves the modules own SOUNDNESS-block autocorrelation caveat (updated in place).Same subset logic as the anti-sybil switch:
margin_corrected ≥ margin_iid⇒ can only remove falseAboveClassicalBoundverdicts, never add. The streams are already in hand at both call sites (no signature change). The i.i.d.chshMarginstays exported for callers who explicitly want it.Tests
8 DecorrelationMeter tests green with no fixture changes — the s4 fixtures autocorrelation is mild enough that
|S|=4still clears the corrected bound at n=100; the tiny-n non-conviction and identical-pair (S=2) tests hold a fortiori. Core 0-warning.This was the flagged one-line follow-up from #10027 — the last i.i.d.-
chshMarginconviction site is now aligned.🤖 Generated with Claude Code