Repository navigation
fix(ci): drop orphaned loop keywords from the manifest step - #3
Merged
Merged
Conversation
The manifest step lost its surrounding for-loop when it was reduced to a single tag, but kept the trailing `break`/`done`. Bash rejects the step with "syntax error near unexpected token 'done'", so docker-image-publish fails on any push that reaches it. YAML parsing cannot catch this: inside a block scalar the leftover keywords are just text.
ykhrustalev
force-pushed
the
ykhrustalev/fix-manifest-step
branch
from
August 11, 2026 02:13
61f645b to
33c2c19
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
docker-image-publishfails withsyntax error near unexpected token 'done'. When the manifest step was reduced to publishing a single tag, its surroundingforloop was removed but the trailingbreak/donewere left behind. YAML parsing does not catch this — inside a block scalar they are just text.Solution
Testing
run:block in the workflow and ranbash -nover it; clean afterwards