Repository navigation
Converge PTOAS on PTO ISA 0.57.1 - #3
Merged
Merged
Conversation
The dialect and bytecode layer still admitted retired operations and underspecified direct-operation roles, allowing non-normative IR to survive into downstream lowering. Replace those surfaces with the exact 120-operation contract, make ACCCVT use an implicit accumulator, enforce TPREFETCH bounds, and reserve deleted bytecode identities.\n\nConstraint: PTO-ISA/pto-spec is the sole normative source and all deleted D-class operations must disappear.\nRejected: Keep dialect aliases or remap old bytecodes | both would preserve an unintended compatibility ABI.\nConfidence: high\nScope-risk: broad\nDirective: Keep the 120-entry role/arity snapshot exact and regenerate only from the locked PTO 0.57.1 manifest.\nTested: LLVM 23 build; targeted lit 9/9; targeted CTest 3/3; exact 120/120 manifest roles and arity; PTOBC coverage and roundtrip; injected contract-drift failures; git diff check\nNot-tested: complete repository test suite
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
added 2 commits
July 31, 2026 02:40
PTOAS previously pinned only the encoding-era release fields. Validate the complete canonical catalog, content, hardware-profile, and numeric-vector identity while keeping numeric execution outside the assembler's conformance claim. Constraint: PTO-ISA/pto-spec commit 0141ec89 is the sole 0.57.1 source Rejected: Infer numeric execution support from assembler identity | PTOAS does not execute Tile arithmetic Confidence: high Scope-risk: narrow Directive: Keep the PTOAS lock byte-identical to the LinxISA 0.57.1 lock Tested: source-tree and 120-contract checks; exact 98/9/13 inventory; opcode coverage; clean pto-opt+ptobc build; 14 relevant CTests; Python compile; git diff check Not-tested: full pre-existing CTest/lit baselines with known unrelated failures
Close the remaining PTOBC operand-mask and structured-control-flow schema gaps, keep MX verification consistent with A5 low-precision inputs, and make stage9 compare canonical generic MLIR so default attributes survive byte re-encoding. Constraint: PTOAS consumes the frozen 0.57.1 public operation contract while LLVM 21 still has unrelated EmitC and lowering baseline failures. Rejected: Relax byte-for-byte stage9 comparison | it would hide schema drift in optional operands and structured-control-flow results. Confidence: high Scope-risk: moderate Directive: Keep alloc_tile optional-mask bits in ODS operand order and validate new variable-result ops with byte-for-byte round trips. Tested: 16/16 CTest; 9/9 frozen targeted lit; 3/3 MX and TSORT lit; exact 120-op manifest; opcode coverage; git diff --check Not-tested: 143 pre-existing full-lit failures across LLVM 21 EmitC, unlowered ops, FileCheck drift, assertions, and subview expectations
14 tasks done
zhoubot
marked this pull request as ready for review
August 2, 2026 12:09
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PTO-ISA/pto-specrelease identity, encoding projection, hardware profile, and numeric-vector hashesalloc_tileoptional-operand encoding, structured-control-flow variable results/operands, A5 MX low-precision verification, and canonical stage9 byte re-encodingDepends on PTO-ISA/pto-spec#19
Validation
140ODS operations /175v0 bytecode entries)git diff --checkThe LLVM 21 full-lit baseline is 75/218 passing, one more than before this closure pass. The remaining 143 failures are classified existing gaps: 55 unsupported EmitC lvalues, 53 unlowered/deleted PTO operations, 27 output/FileCheck drift cases, 6 LLVM casting assertions, and 2 subview result-type expectation mismatches.
Final LinxISA superproject repinning and end-to-end bring-up are tracked in LinxISA/linx-isa#161.
Final merged-source refresh (2026-08-02)