fix: load checkpoints with torch.load(weights_only=True)#2287
Open
Solaris-star wants to merge 1 commit into
Open
fix: load checkpoints with torch.load(weights_only=True)#2287Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
Untrusted .pth checkpoints can execute arbitrary code via pickle when loaded with weights_only=False (or omitted). Prefer weights_only=True for model weight loads in the API, utils, merge/convert scripts, generate paths, and eval conversion helper. Fixes Lightning-AI#2189 Signed-off-by: Solaris-star <820622658@qq.com>
Solaris-star
requested review from
andyland,
k223kim and
lianakoleva
as code owners
July 21, 2026 03:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several production paths loaded
.pthcheckpoints withweights_only=Falseor withoutweights_only, which allows pickle gadget execution from untrusted files.Set
weights_only=Truefor model weight loads in:litgpt/api.pylitgpt/utils.py(load_checkpointModelParallel path)litgpt/scripts/convert_pretrained_checkpoint.pylitgpt/scripts/merge_lora.pylitgpt/generate/sequentially.py/tp.pylitgpt/eval/evaluate.pyconversion helperTesting
torch.loadcall sitesFixes #2189