Skip to content

fix(rtl): horizontal list renders blank in a native-RTL app #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mohamed-kassim wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rtl): horizontal list renders blank in a native-RTL app #483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/components/ListComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import { useArr$, useStateContext } from "@/state/state";
import { type GetRenderedItem, type LegendListPropsBase, typedMemo } from "@/types.internal";
import { IS_DEV } from "@/utils/devEnvironment";
import { getComponent } from "@/utils/getComponent";
import { isHorizontalRTL } from "@/utils/rtl";

interface ListComponentProps<ItemT>
extends Omit<
Expand Down Expand Up @@ -200,7 +201,18 @@ export const ListComponent = typedMemo(function ListComponent<ItemT>({
onScroll={onScroll}
ref={refScrollView as any}
ScrollComponent={snapToIndices ? ScrollComponent : (undefined as any)}
style={autoOtherAxisStyle ? [autoOtherAxisStyle, style] : style}
// RTL is emulated in logical (LTR) coordinates with item positions mirrored
// in JS, so the scroll container must stay LTR. On web that's done per-item
// (Container.tsx); on native the container itself also flips under
// I18nManager.isRTL, and the double flip renders the list blank — so
// neutralize the native flip here too. See #477. Keep this array flat: the
// web scroll view flattens it shallowly, so a nested array would drop the
// measured cross-axis size.
style={[
isHorizontalRTL(ctx.state) && Platform.OS !== "web" ? { direction: "ltr" } : null,
autoOtherAxisStyle,
style,
]}
>
<ScrollAdjust />
{ListHeaderComponent && (
Expand Down