Skip to content

fix: scroll to the model end offset in doMaintainScrollAtEnd instead of native scrollToEnd #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mperonnet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: scroll to the model end offset in doMaintainScrollAtEnd instead of native scrollToEnd #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/core/doMaintainScrollAtEnd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,19 @@ export function doMaintainScrollAtEnd(ctx: StateContext) {
y: 0,
});
} else {
scroller?.scrollToEnd({
// Use the model-computed end offset instead of the native
// scrollToEnd command. The native command computes its target
// from the native contentSize + contentInset at execution time,
// which desyncs from the model when a contentInset update is
// still in flight (e.g. an inset animated via Reanimated on
// Fabric lands a frame or more later) — scrollToEnd then stops
// exactly insetEnd short of the model's end position.
const currentContentSize = getContentSize(ctx);
const endOffset = Math.max(0, currentContentSize - state.scrollLength);
scroller?.scrollTo({
animated: maintainScrollAtEnd.animated,
x: state.props.horizontal ? endOffset : 0,
y: state.props.horizontal ? 0 : endOffset,
});
}
setTimeout(
Expand Down