Repository navigation
fix: TierEditor inputs, password single source of truth, bundle route, Textarea stories, e2e workflow - #1175
Merged
BigBen-7 merged 2 commits intoOct 18, 2026
Conversation
…1097 Lead-Studios#1098 and workflow bug Lead-Studios#1097 — rename /events/create to /dashboard/events/new in BUNDLE_BUDGET.md and scripts/check-bundle-budget.mjs so the CI budget step no longer reports a missing route and fails. Lead-Studios#1096 — build passwordSchema from PASSWORD_RULES with a single superRefine loop so the strength checklist and the Zod validator share one source of truth and can never drift apart. Lead-Studios#1095 — replace the readOnly name Input in TierEditor with a live onChange handler, add price (minor units) and quantity number inputs, and key rows by a stable counter id so removing a row does not shift focus to adjacent rows. Lead-Studios#1098 — add src/components/ui/textarea.stories.tsx covering the Default, Disabled, Error (aria-invalid), and CharacterCounter states, matching the pattern established by the other 22 ui primitive stories. workflow — switch e2e.yml from a hardcoded node-version: "20" to node-version-file: ".nvmrc" so all three workflows (ci.yml, e2e.yml, lighthouse.yml) use the same Node version.
|
@hikmat67-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes four issues assigned to me plus one pre-existing workflow bug found during review.
Closes #1097 — Bundle budget references a route that does not exist
Renamed
/events/create→/dashboard/events/newin:BUNDLE_BUDGET.md(the table row)scripts/check-bundle-budget.mjs(theLIMITSmap)The CI Bundle budget step was reporting that route as
missingand failing on every passing build.Closes #1096 — passwordSchema and PASSWORD_RULES can drift
Replaced the four chained
.regex()calls inpasswordSchemawith a singlesuperRefinethat iteratesPASSWORD_RULES. There is now exactly one place to add or remove a password policy rule; the strength checklist and the Zod validator share the same array and can no longer drift.All 10 existing password tests continue to pass.
Closes #1095 — TierEditor name is readOnly with no price or quantity inputs
readOnlyfrom the nameInputand wired anonChangehandler.Closes #1098 — Textarea has no Storybook story
Added
src/components/ui/textarea.stories.tsxwith four stories:DefaultDisableddisabledprop; muted appearance, not focusableErroraria-invalidring plus associated error messageCharacterCounterWorkflow fix —
e2e.ymlused a hardcoded Node versionReplaced
node-version: "20"withnode-version-file: ".nvmrc"so all three CI workflows (ci.yml,e2e.yml,lighthouse.yml) read the same single source of truth. The comment in the file already noted this switch was needed.Testing
npm run lint— passes on all changed files (pre-existing errors on other files are unchanged frommain)npm test— 326 passing; the 2 pre-existing failures (analytics.test.ts,csv.test.ts) reproduce onmainunchanged