Repository navigation
fix: audit fixes for splitter reads, xlmToStroops, sideEffects and tsconfig strictness - #960
Merged
Merged
Conversation
Closes Lead-Studios#857 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oint getSplit, getSplitsByRecipient and getPendingSplits called get_split, get_splits_by_recipient and get_pending_splits, none of which the contract defines. Throw VeriTixErrorCode.NotImplemented naming the missing entrypoint instead of issuing calls that always fail. Closes Lead-Studios#854 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes Lead-Studios#855 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes Lead-Studios#857 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closes Lead-Studios#856 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@feyishola Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes four findings from the audit of main @ 3c1bb6e. There is one commit per issue.
Changes
getSplit(),getSplitsByRecipient()andgetPendingSplits()calledget_split,get_splits_by_recipientandget_pending_splits, but the contract defines none of them. They now throwVeriTixErrorCode.NotImplementedand name the missing entrypoint, so callers get a clear error instead of a failed call.getSplitsBySenderis unchanged.noUncheckedIndexedAccessand fix the one resulting error #857: EnablesnoUncheckedIndexedAccessand fixes the one error it raises.xlmToStroopsnow checks the destructuredwholePartbefore callingBigInt(wholePart).noImplicitOverridein tsconfig.json #856: EnablesnoImplicitOverride. This adds no new errors.sideEffects: falsein package.json #855: Adds"sideEffects": falsetopackage.json. No module insrc/has top-level expression statements or call-time initializers, andsrc/timers.d.tscontains only declarations.Verification
tsc --noEmitshows the same 9 errors asmain, all inclient.ts,escrow.ts,token.tsandrecurring.ts. None are new, and theformat.ts:71error is gone.mainexactly: 55 of 67 suites fail and 59 tests pass. Those suites already fail onmainbecause of the type errors above.dist/index.jsis about 18 KB anddist/index.mjsis about 17.8 KB, well under the 150 KB.size-limit.jsonbudget.Notes
npm run size,npm run buildand the Jest TS config needsize-limitand a size-limit plugin,tsupandts-node, but none of these are indevDependencies. For this PR I installed them with--no-save.Closes #854
Closes #855
Closes #856
Closes #857
🤖 Generated with Claude Code