Skip to content

modules/noctalia: init#169

Merged
zimward merged 1 commit into
Lassulus:mainfrom
sometreee:noctalia
Jul 10, 2026
Merged

modules/noctalia: init#169
zimward merged 1 commit into
Lassulus:mainfrom
sometreee:noctalia

Conversation

@Kruemmelspalter

@Kruemmelspalter Kruemmelspalter commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

waiting for

@Kruemmelspalter Kruemmelspalter changed the title WIP: add noctalia module modules/noctalia: init Jun 11, 2026
@zimward

zimward commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

ah the failure is to be expected given that its not yet in nixpkgs ig. guess i need to update the flake lock once its merged

@zimward

zimward commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

otherwise looks like any of the simple modules so far, so nothing to nitpick from my side

@Kruemmelspalter Kruemmelspalter marked this pull request as ready for review June 17, 2026 16:31
@Kruemmelspalter

Kruemmelspalter commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

as of NixOS/nixpkgs#530804, the noctalia package will probably not be upstreamed into nixpkgs until v5 is actually released
until then, I added the package build directly in here and will switch it over when it lands in nixpkgs

@Kruemmelspalter Kruemmelspalter force-pushed the noctalia branch 3 times, most recently from 64012ce to 158933a Compare June 17, 2026 17:12
@Kruemmelspalter Kruemmelspalter force-pushed the noctalia branch 3 times, most recently from d606392 to feb518b Compare July 1, 2026 13:00
@Kruemmelspalter

Kruemmelspalter commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

the package now has to be supplied when calling the module like

wrapperModules.noctalia.apply {
  inherit pkgs;
  package = <package>;
  settings = <...>;
}

@zimward

zimward commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

the package now has to be supplied when calling the module like

wrapperModules.noctalia.apply {
  inherit pkgs;
  package = <package>;
  settings = <...>;
}

you still need to remove the check then because there is no package to actually drive it

@zimward zimward left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimward zimward merged commit 05b06e5 into Lassulus:main Jul 10, 2026
2 checks passed
@Kruemmelspalter Kruemmelspalter deleted the noctalia branch July 10, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants