Skip to content

core: make presentation error mapping exhaustive #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lemone112 merged 1 commit into from
Jul 27, 2026
Merged

core: make presentation error mapping exhaustive #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions crates/labcolors-core/src/program_identity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,9 +329,9 @@ where
fn program_root_color() -> Result<VertexColorV1, ProgramCompileError> {
let mut color = VertexColorV1::new(vertex_tag::PROGRAM);
// Эти теги связывают адрес с версиями исполняемых законов: схемой Program,
// total-order selection, финальной перепроверкой, атомарным наблюдением и
// encoded Paint emission. Derived capability releases bind only the
// constraints that execute them.
// total-order selection, финальной перепроверкой, атомарным наблюдением,
// encoded Paint emission и modeled point presentation. Derived capability
// releases bind only the constraints that execute them.
for release in [
release_tag::PROGRAM_SCHEMA_V3,
release_tag::DECLARED_TOTAL_ORDER_V1,
Expand Down
14 changes: 12 additions & 2 deletions crates/labcolors-core/src/program_session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3184,7 +3184,12 @@ fn compile_point_presentations(
PointPresentationPathErrorV1::ResourceExhausted => {
ProgramCompileError::ResourceExhausted
}
_ => ProgramCompileError::InternalInvariant,
PointPresentationPathErrorV1::MissingTarget
| PointPresentationPathErrorV1::TargetOutsideRootAncestry
| PointPresentationPathErrorV1::IncompatibleRoot
| PointPresentationPathErrorV1::InternalInvariant => {
ProgramCompileError::InternalInvariant
}
})?;
compiled_roots.push((root.id, compiled));
}
Expand Down Expand Up @@ -3230,7 +3235,12 @@ fn compile_point_presentations(
PointPresentationPathErrorV1::ResourceExhausted => {
ProgramCompileError::ResourceExhausted
}
_ => ProgramCompileError::InternalInvariant,
PointPresentationPathErrorV1::MissingRoot
| PointPresentationPathErrorV1::RootConsumedDownstream
| PointPresentationPathErrorV1::IncompatibleRoot
| PointPresentationPathErrorV1::InternalInvariant => {
ProgramCompileError::InternalInvariant
}
})?;
compiled.push(CompiledPointPresentationV1 {
root: target.root,
Expand Down
Loading