C8b: единый точечный композитор Core - #357
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughВ Core централизованы профили композиции и admitted alpha, добавлен точечный WASM-композитор, а ChangesКомпозиция и WASM bridge
Интеграция и проверка
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant effectiveBackground
participant __over
participant composite_over_srgb8
effectiveBackground->>__over: Передаёт packed source, opacity и backdrop
__over->>composite_over_srgb8: Выполняет Core-композицию
composite_over_srgb8-->>__over: Возвращает RGB24 или отказ
__over-->>effectiveBackground: Возвращает packed результат
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/labcolors-core/src/appearance.rs`:
- Around line 1036-1050: Update SourceOverCertificateV1::replay to avoid
revalidating subject_opacity_bits through AdmittedOpacityV1::new; add a trusted
pub(crate) AdmittedOpacityV1::from_bits(bits: u64) constructor that performs
only the round-trip conversion, then use it in replay while preserving the
existing compositing behavior.
In `@crates/labcolors-core/src/composition.rs`:
- Around line 56-61: Добавьте прямой unit-тест для AdmittedOpacityV1::multiply,
проверяющий граничные случаи 0.0*0.0, 1.0*1.0 и перемножение значений,
денормализующееся до 0.0. Сравнивайте результат через публичное значение opacity
и закрепите инвариант, что результат остаётся admitted.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: fdfcf677-f365-42b0-b638-1c2167804269
📒 Files selected for processing (25)
README.mdcrates/labcolors-core/src/alpha.rscrates/labcolors-core/src/appearance.rscrates/labcolors-core/src/composition.rscrates/labcolors-core/src/semantic.rscrates/labcolors-wasm/src/lib.rspackages/colors/README.mdpackages/colors/adapt-theme.d.tspackages/colors/adapt-theme.jspackages/colors/bench/hotpath.bench.mjspackages/colors/bench/wasm.jsonpackages/colors/effective-bg.jspackages/colors/index.d.tspackages/colors/index.jspackages/colors/test/adapt-theme.test.mjspackages/colors/test/chain-invariants.test.mjspackages/colors/test/init-lifecycle.test.mjspackages/colors/test/oklch-parse.test.mjspackages/colors/test/point-composition.test.mjspackages/colors/test/public-api-cleanup.test.mjspackages/colors/test/release-contract.test.mjspackages/colors/test/runtime.test.mjspackages/colors/watch-theme.d.tspackages/colors/watch-theme.jsscripts/check-wasm-size-budget.mjs
1 participant
Изменение
RED → GREEN
Проверки
Размер
Canonical Linux run 29701262743 измерил 387058 B raw, на 77 B меньше base-ратчета 387135 B. Policy имеет нулевой произвольный headroom: ceiling = measurement = 387058 B; gzip остаётся diagnostic-only.
Summary by CodeRabbit
Новые возможности
Исправления
fallbackтеперь должен быть распознаваемым непрозрачным поддерживаемым цветом.Документация
fallback, композиции цветов и поведения инициализации.