refactor!: C4b — excise the explicit-feasibility capability - #341
Merged
Conversation
The client-declared explicit finite domain was the second rung of the parallel WCAG product line (root-cause map §15). With the selection/atomic operation gone (#339), the explicit-feasibility module had no consumer left outside its own tests. Removed leaf-first with zero shims; neutral feasibility, the exact evaluateWcag22 evaluator and the Q55 proofs stay. Removed: - core: wcag22_feasibility/explicit.rs, the wcag22-explicit-feasibility feature (defaults are now exactly ["wcag22-feasibility"]), the three candidate InvalidRequestV1 variants and their Display arms, the cfg-gated kernel plumbing (write_feasible_candidate, VariablePackingV1, PackedDecisionStorage::into_bytes), eight cfg-gated tests, the explicit integration test target and its identity contract artifact; - scripts/verify_wcag22_explicit_feasibility_identity.py and its CI step; - ci.yml capability projection: core defaults assertion narrowed; the anti-resurrection guards now reject ANY "wcag22-explicit" token in consumer/compiler feature trees (the feature no longer exists at all); - core README documents one registered input; the explicit example and its silently-dead cfg-gated doctest are gone. Gates: workspace 0 failed, clippy -D warnings clean, rustdoc -D warnings clean, fmt clean, MSRV 1.85 clean, npm 185/185, tsc clean. Compiler wasm is expected byte-identical (the role has resolved core without the feature since #339) — the draft CI round verifies; no budget change anticipated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (5)
WalkthroughChangesPR удаляет explicit WCAG 2.2 feasibility из Удаление explicit feasibility
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Collaborator
Author
|
@coderabbitai review |
…cost-model sentence - ci.yml runtime forbidden-list uses the same broad 'wcag22-explicit' token as the consumer/compiler guards (the narrow deleted-feature string could never fire); - core README restores the cost-model sentence in its neutral form: the C×E formula does not mask declaration scanning, ID-byte relation sorting, adjacency sorting and linear canonical hashing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
lemone112
marked this pull request as ready for review
July 17, 2026 12:51
Collaborator
Author
|
@coderabbitai full review |
✅ Action performedFull review finished. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roadmap §16 C4b. DRAFT: CI-раунд подтверждает байт-идентичность обеих WASM-ролей (compiler резолвит core без фичи со времён #339, runtime её никогда не имел) — бюджет не должен двигаться; затем undraft.
🤖 Generated with Claude Code
Summary by CodeRabbit
Изменения
Документация
Тесты