Skip to content

Facet-imaging updates - #155

Open
jurjen93 wants to merge 26 commits into
masterfrom
facet_imaging_upd
Open

Facet-imaging updates#155
jurjen93 wants to merge 26 commits into
masterfrom
facet_imaging_upd

Conversation

@jurjen93

@jurjen93 jurjen93 commented Aug 7, 2026

Copy link
Copy Markdown
Member

Update to the facet imaging workflow. The updates include:

  • An option to provide extra averaging of the input MS (useful for lower resolution imaging). This needed a ValueFrom fix in the sort_mses step, because if the averaging is not used it returns an array with [null, null, ...], which first_non_null does not pick up as null.
  • An option to provide the briggs weighting to the facet-imaging workflow
  • An option to provide ncpu to the facet-imaging workflow for running WSClean imaging. If not given, the ncpu for WSClean is calculated based on the image size (scales between 8 and 64 cores in steps of 4).
  • Fixes for label names
  • Fix for warning when returning PSF images

@jurjen93
jurjen93 requested a review from tikk3r August 7, 2026 11:04
@jurjen93 jurjen93 changed the title Facet imaging upd Facet-imaging updates Aug 7, 2026
Comment thread steps/dp3_avg_step.cwl

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this step is best combined with steps/dp3_prep_phasediff.cwl. That only does averaging as well.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can do this in a separate MR. Will add a ticket to the LOFAR-VLBI ticket board

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would carry finishing this PR over to the busy week then. It feels a bit moot to add a step and then immediately have another PR removing it already planned for the next weeks.

Comment thread workflows/subworkflows/image_and_trim.cwl
Comment thread workflows/facet_imaging.cwl Outdated
Comment thread workflows/facet_imaging.cwl Outdated
Comment thread workflows/facet_imaging.cwl Outdated
jurjen93 and others added 3 commits August 7, 2026 15:28
@jurjen93
jurjen93 requested a review from tikk3r August 7, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants