Fixes slicing ValueColumn<AnyFrame?> -> FrameColumn#1928
Open
Jolanrensen wants to merge 3 commits into
Open
Conversation
…return a FrameColumn
koperagen
reviewed
Jul 10, 2026
| it.type().isSubtypeOf(typeOf<DataFrame<*>>()) shouldBe true | ||
| } | ||
|
|
||
| df["col"].dropNulls() // should work correctly |
Collaborator
There was a problem hiding this comment.
wrap with shouldNotThrow
koperagen
reviewed
Jul 10, 2026
|
|
||
| df["col"].dropNulls() // should work correctly | ||
| val droppedDf = df.dropNulls("col") | ||
| droppedDf["col"].let { |
Collaborator
There was a problem hiding this comment.
please split into multiple tests
Collaborator
There was a problem hiding this comment.
nested class if you prefer to have some common "subject under test"
Collaborator
Author
There was a problem hiding this comment.
Actually, I think this test(s) should probably be moved elsewhere anyways, since we don't necessarily test drop, but some lower level functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1926 by letting slicing operations on ValueColumn potentially return a FrameColumn.
Like #1925 this points at a deeper issue with the way we handle dataframes inside columns, but at least does this make it consistent with
update,convert,replaceetc.