test(viewer): session-ledger bundle compiler proptest surface (WBS-6.2 #471) - #490
test(viewer): session-ledger bundle compiler proptest surface (WBS-6.2 #471)#490KooshaPari wants to merge 0 commit into
Conversation
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:XXL
|
Warning Review limit reached
Next review available in: 12 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| /// Every `Acceptance` extractor field (evidence, user_confirmed, | ||
| /// testing_evidence, satisfaction_score) carries through unchanged from | ||
| /// the extracted `Acceptance` struct into the bundle body. The compiler |
There was a problem hiding this comment.
Suggestion: The test claims to verify every extracted Acceptance field is carried through, but it never compares extracted.satisfaction_score with the serialized satisfaction_score. A compiler that drops, renames, or alters that field can pass this property; the separate upper-bound check does not detect value changes within the valid range. [api mismatch]
Severity Level: Major ⚠️
- ⚠️ Acceptance score changes can alter resume readiness.
- ⚠️ Viewer satisfaction indicators may show incorrect values.
- ⚠️ Serialized acceptance data can diverge from extraction.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_session_ledger_bundle_compiler.rs
**Line:** 325:327
**Comment:**
*Api Mismatch: The test claims to verify every extracted Acceptance field is carried through, but it never compares `extracted.satisfaction_score` with the serialized `satisfaction_score`. A compiler that drops, renames, or alters that field can pass this property; the separate upper-bound check does not detect value changes within the valid range.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| let body = format!("the {pat} is rust"); | ||
| let messages = vec![(Role::User, body.as_str())]; | ||
| let session = make_session("criteria-coverage", &messages); | ||
| let c = HeuristicContractExtractor::extract_contract(&session); |
There was a problem hiding this comment.
Suggestion: The contract extractor's role behavior is not covered: all pattern tests construct only Role::User messages. Because the session model has distinct assistant, subagent, tool, and system roles, the suite cannot detect a regression that incorrectly includes or excludes those roles despite the documented extractor contract. Add role-specific cases, especially assistant content that must not be treated as user contract input if that is the intended contract. [api mismatch]
Severity Level: Major ⚠️
- ⚠️ Non-user contract contamination lacks regression coverage.
- ⚠️ Tool or system text may affect acceptance contracts.
- ⚠️ Contract slices can diverge from documented role semantics.
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** crates/sl-viewer/tests/properties_session_ledger_contract.rs
**Line:** 155:158
**Comment:**
*Api Mismatch: The contract extractor's role behavior is not covered: all pattern tests construct only `Role::User` messages. Because the session model has distinct assistant, subagent, tool, and system roles, the suite cannot detect a regression that incorrectly includes or excludes those roles despite the documented extractor contract. Add role-specific cases, especially assistant content that must not be treated as user contract input if that is the intended contract.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
801a12b to
3a39a89
Compare
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
size:XL
3a39a89 to
f445859
Compare
Code Review SummaryStatus: No Issues Found | Recommendation: N/A (PR is closed, no diff available) Files Reviewed (0 files)No changed files were available for review; the PR is closed and head and base refs are identical. Reviewed by step-3.7-flash · Input: 52.1K · Output: 3.1K · Cached: 285.8K |
User description
WBS-6.2 surface 11: session-ledger distill pipeline.
Branch off fix/viewer-mock-data-properties-20260809 rebased main. Test file compiles and passes locally.
CodeAnt-AI Description
Add property coverage for session-ledger bundle compilation
What Changed
Impact
✅ Fewer malformed continuation bundles✅ Reliable resume prompts for empty sessions✅ Clearer propagation of bundle extraction failures💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.