fix(FPSMonitor): fix FPSMonitor for float numbers - #3584
Open
Jo-Byr wants to merge 1 commit into
Open
Conversation
Limit float number digits to 6 Fix wrong output of formatNumbers for float numbers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
FPSMonitor has 2 issues with float numbers:
They make the display incorrect for float numbers > 1000. For example, for input
123456789.01we expect output "123'456'789.01" or "123'456'789" if we consider decimals negligible, but we actually got "123'456'644'" due toslice(-3)taking the digits into consideration (123456789.01 % 1000 === 789.0100000053644)There is no size limit so we sometimes had outputs such as "0.010775999999999999"
Results
digits are limited to 6 with
toFixedDigits are truncated for numbers > 1000
PR and Code Checklist
npm run reformatto have correctly formatted code