Fix interactor style trackball camera mouse wheel event - #3581
Open
Jo-Byr wants to merge 2 commits into
Open
Conversation
Replace mouse wheel to dolly factor formula by negative exponential for symmetry and to fix impossibility to dezoom at zoomFactor = 1
Jo-Byr
force-pushed
the
fix-interactor-style-trackball-camera-mouse-wheel-event
branch
from
July 27, 2026 09:37
a132657 to
53e947f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
InteractorStyleTrackballCamera's mouseWheel to dolly factor formula has 2 issues:
Results
The new formula is symetrical and never reaches 0 to always allow zooming and dezooming.
Changes
Replaced the formula
dollyFactor = 1 - spin / zoomFactorbydollyFactor = exp(- spin / zoomFactor)PR and Code Checklist
npm run reformatto have correctly formatted code