Skip to content

Fix double-underscore shader conformance tests - #3789

Open
yudshj wants to merge 1 commit into
KhronosGroup:mainfrom
yudshj:fix/double-underscore-cts
Open

Fix double-underscore shader conformance tests#3789
yudshj wants to merge 1 commit into
KhronosGroup:mainfrom
yudshj:fix/double-underscore-cts

Conversation

@yudshj

@yudshj yudshj commented Aug 8, 2026

Copy link
Copy Markdown

Summary

  • make the double-underscore test use a valid vertex-to-fragment varying
  • remove __foo and foo__bar from the reserved-word rejection list

Rationale

PR #3761 changed the WebGL 1.0 language so defining an identifier containing two consecutive underscores does not itself produce an error, and added shader-with-double-underscore.html to exercise that behavior.

Two CTS details currently obscure that behavior:

  1. The fragment shader in the new test declares an attribute, which is not valid in an ESSL 1.00 fragment shader. The test therefore fails independently of the identifier under test.
  2. shader-with-reserved-words.html still expects __foo and foo__bar to be rejected, contradicting the behavior established by Allow double-underscore e.g. foo__bar in shader identifiers. #3761.

This change gives the test a valid varying interface and removes the two stale reserved-word cases. Implementations that do not support the updated double-underscore behavior will continue to fail the dedicated test for the intended reason.

Fixes the CTS follow-up from #3649 and #3761.

Testing

  • python3 sdk/tests/py/lint/lint.py -p
  • git diff --check

@CLAassistant

CLAassistant commented Aug 8, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants