Fix double-underscore shader conformance tests - #3789
Open
yudshj wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__fooandfoo__barfrom the reserved-word rejection listRationale
PR #3761 changed the WebGL 1.0 language so defining an identifier containing two consecutive underscores does not itself produce an error, and added
shader-with-double-underscore.htmlto exercise that behavior.Two CTS details currently obscure that behavior:
attribute, which is not valid in an ESSL 1.00 fragment shader. The test therefore fails independently of the identifier under test.shader-with-reserved-words.htmlstill expects__fooandfoo__barto be rejected, contradicting the behavior established by Allow double-underscore e.g. foo__bar in shader identifiers. #3761.This change gives the test a valid varying interface and removes the two stale reserved-word cases. Implementations that do not support the updated double-underscore behavior will continue to fail the dedicated test for the intended reason.
Fixes the CTS follow-up from #3649 and #3761.
Testing
python3 sdk/tests/py/lint/lint.py -pgit diff --check