Support Vulkan Loader and VVL on iOS Simulator for SDKs >= 1.4.357 - #1572
Open
SRSaunders wants to merge 4 commits into
Open
Support Vulkan Loader and VVL on iOS Simulator for SDKs >= 1.4.357#1572SRSaunders wants to merge 4 commits into
SRSaunders wants to merge 4 commits into
Conversation
Contributor
Author
|
I don't understand why Clang Tidy is failing. No useful error message: The only thing that seems off is the following message from cmake in the setup, for a file I did not touch (this may be a red herring since earlier successful runs seem to show this as well): |
Contributor
Author
|
There may be something wrong in the CI environment that is causing Clang Tidy to fail. When I run the same cmake setup and run-clang-tidy command locally on my Manjaro Linux box, it runs fine with no errors. |
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Vulkan SDK 1.4.357 now includes support for the Vulkan Loader and Vulkan Validation Layer (VVL) on the iOS Simulator. New .xcframework packages are available in the SDK that include these target libraries.
This PR adds support for these new target libs in the Vulkan-Samples build system for Vulkan SDKs >= 1.4.357.
This PR also fixes a
bind_vertex_buffers()boundary validation error in gui.h specifically for the iOS Simulator. This was discovered once the VVL was available to run on that target.Fixes #1571.
Tested on macOS Sequoia x86_64 running the iOS Simulator. Regression tested on macOS Sequoia native. Since these changes are guarded by iOS Simulator
#ifdefguards, there should be no need to worry about other platforms.General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: