Skip to content

typos2 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ViPErCZ wants to merge 1 commit into from
Closed

typos2 #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Kdyby/RabbitMq/AmqpMember.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ abstract class AmqpMember extends Nette\Object
{

/**
* @var Connection
* @var IConnection
*/
protected $conn;

Expand Down Expand Up @@ -94,10 +94,10 @@ abstract class AmqpMember extends Nette\Object


/**
* @param Connection $conn
* @param IConnection $conn
* @param string $consumerTag
*/
public function __construct(Connection $conn, $consumerTag = null)
public function __construct(IConnection $conn, $consumerTag = null)

@fprochazka fprochazka Jul 6, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would break the contact of the interface. Why is this needed?

@ViPErCZ ViPErCZ Jul 8, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need use SSLConnection (https://github.com/php-amqplib/php-amqplib/blob/master/PhpAmqpLib/Connection/AMQPSSLConnection.php) instead of Connection.

{
$this->conn = $conn;
$this->consumerTag = empty($consumerTag) ? sprintf("PHPPROCESS_%s_%s", gethostname(), getmypid()) : $consumerTag;
Expand Down