Manual duplex printing helper #83 - #205
Conversation
dominik-korsa
left a comment
dominik-korsa
left a comment
There was a problem hiding this comment.
Your changes are chaotic and break existing functionality. Please review the changes you submit in this pull request.
As explained previously, please also make sure to stick to English, both in the user interface and code (including code comments). In this pull request you seem to be mixing both in new UI strings.
It's fine to use Polish in comments on GitHub, if writing them in English would be a challenge for you.
There was a problem hiding this comment.
Do not commit your modified docker-compose.yml
There was a problem hiding this comment.
Revert these accidental (?) changes
There was a problem hiding this comment.
Why not put these instructions for performing the second print in the job page, which the user gets redirected to after they submit a print job?
There was a problem hiding this comment.
The path of the docker_settings.py.example is backend/gutenberg/settings/docker_settings.py.example, why copy it?
| urlpatterns = [ | ||
| # ... istniejące ścieżki ... | ||
| path('jobs/<int:job_id>/duplex-info/', views.get_duplex_instructions, name='duplex-info'), | ||
| path('jobs/<int:job_id>/resume-duplex/', views.resume_manual_duplex_job, name='resume-duplex'), | ||
| ] |
There was a problem hiding this comment.
The LLM-generated comment instructed you that you should modify the urlpatterns list instead of overriding it. C'mon.
There was a problem hiding this comment.
Please read what you commit... You just deleted used functions here and comments meant as a baseline for implementing scanner support in the future.
| PRINTING = 'PRINTING', _('printing') | ||
| # SCANNING = 'SCANNING', _('scanning') | ||
| # WAITING_FOR_NEXT_PAGE = 'WAITING_PAGE', _('waiting for next page') | ||
| WAITING_FOR_MANUAL_DUPLEX = 'WAITING_DUPLEX', _('waiting for paper flip') # <-- Nowy status |
There was a problem hiding this comment.
Do not describe changes in the comments. Comments persist in the codebase after merging your PR, this comment is useless for trying to understand the code in the future.
| manual_duplex_supported = models.BooleanField( | ||
| default=False, | ||
| help_text=_("Check if the printer supports manual (software-guided) two-sided printing.") | ||
| ) |
There was a problem hiding this comment.
What is this field used for? Is your feature making use of two-sided printing helpers built into printers?
There was a problem hiding this comment.
These should be action views in backend/api/views.py. Please try to follow the existing structure of the project
… into feature/paper-size
2 participants
Zrobiony task z ręcznym drukowaniem dwustronnym.
Funkcja calculate_duplex_pages sprawdza liczbę stron w dokumencie. Sprawdza czy ilość stron jest parzysta lub nieparzysta. Jeżeli nieparzysta do jest dodawana pusta strona by zachować parzystość.
Funkcja split_pdf_for_manual_duplex na podstawie oryginalnego PDF'a tworzy jego kopię. Pierwsza kopia jest dla pierwszego przebiegu, druga dla drugiego.
W models.py jest wykonywana pauza w drukowaniu - czekanie na akcję człowieka.
ManualDuplexModal.vue to wzkazówki i wznowienie druku po przełożeniu papieru.
Closes #83