Update Apolyton to OpenRA release-20210503#27
Merged
Conversation
It now matches the .gitattributes files of both the ModSDK and OpenRA. EoL changes were introduced to OpenRA with PR 15274 and merge strategies were removed from OpenRA with PR 16451 The ModSDK .gitattributes file was initially created like this.
- Removed `.travis.yml` based on ModSDK PR 170 - "Compatibility/feature upgrades for playtest-20201213" ("Update scripts, packaging, and example mod for playtest-20201213").
- Updated `fetch-engine.sh` based on ModSDK PR 169 - "Fix a collection of minor issues" ("Update python requirement").
- Updated `launch-dedicated.cmd` based on ModSDK PR 170
- Updated `launch-dedicated.sh` based on ModSDK PRs 169 and 170
... and so on.
Following instructions at https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-Release-20200503-to-Release-20210321 Mirroring OpenRA PR 18846 - "Add a bin directory for generated binaries" ("Replace ^ and . in platform paths with ^SupportDir and ^EngineDir." + "Output compiled binaries to ./bin.")
Following instructions at https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-Release-20200503-to-Release-20210321 Necessitated by OpenRA PR 18425 - "Add ability to right click on map to disable spawn points".
Following instructions at https://github.com/OpenRA/OpenRAModSDK/wiki/Update-notes:-Release-20200503-to-Release-20210321 Taken from OpenRA PR 18633 - "Move shared sound and color definitions to common metrics".
Taken from OpenRA PR 17663 - "Unify widget state image names (disabled, pressed, hover, focused)".
As they had issues with referenced rules files and break the utility when it tries to update the mod.
Owner
|
I am astonished, you updated the entire mod, you did a weeks job in a matter of minutes, your are impressive to say the least! Thank you. Let there be known that @penev92 has no shortage of good will and energy for work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following my steps from OpenRA/ra2#777 and OpenRA/ra2#778 I updated the ModSDK files and parts of the mod to OpenRA release-20210503.
I mostly followed the commits from those PRs and even used the same commit messages.
What remains (for you) are these commits of the original PR: