You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
CloudMicrophysics: cap ClimaParams compat at 1.3.2 for versions 0.42 - 0.45 - #172413
ClimaParams 1.3.3 changed the default of KK2000_autoconversion_coeff_A from 7.42e13 to 1350 and added reference values (KK2000_reference_cloud_droplet_number_concentration, KK2000_reference_air_density) that the Khairoutdinov and Kogan (2000) kernels in CloudMicrophysics must read to produce the same rates (CliMA/ClimaParams.jl#335). CloudMicrophysics versions 0.42 - 0.45 use the old form of the kernel, so with ClimaParams 1.3.3 they compute KK2000 autoconversion rates about 10^11 too small (CloudMicrophysics' own test suite fails on main with 1.3.3). CloudMicrophysics 0.46.0, with the updated kernels and ClimaParams = "1.3.3" compat (CliMA/CloudMicrophysics.jl#814), is being released separately.
This caps ClimaParams at 1.3.2 for CloudMicrophysics 0.42 - 0.45; the entry's version range was 0.42 - 0, which only covers those four released versions today.
Rebased onto current master: CloudMicrophysics 0.46.0 was registered after this PR was opened, which split the ["0.42 - 0"] entry into ["0.42 - 0.45"] and ["0.46 - 0"] and left this PR conflicting. The change is now the single line ClimaParams = "1.2.0 - 1.3.2" under ["0.42 - 0.45"]; the new ["0.46 - 0"] entry already carries the 1.3.3 floor, so the two are consistent.
Context: ClimaParams 1.3.3 changed the default of KK2000_autoconversion_coeff_A and added reference values that only CloudMicrophysics >= 0.46 reads, so 0.42 - 0.45 compute Khairoutdinov-Kogan autoconversion rates about 10^11 too small with 1.3.3 (their own test suites fail). The RegistryCI checks passed on the previous revision. Could a registry maintainer merge this once the checks rerun? Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retroactive compat cap.
ClimaParams 1.3.3 changed the default of
KK2000_autoconversion_coeff_Afrom 7.42e13 to 1350 and added reference values (KK2000_reference_cloud_droplet_number_concentration,KK2000_reference_air_density) that the Khairoutdinov and Kogan (2000) kernels in CloudMicrophysics must read to produce the same rates (CliMA/ClimaParams.jl#335). CloudMicrophysics versions 0.42 - 0.45 use the old form of the kernel, so with ClimaParams 1.3.3 they compute KK2000 autoconversion rates about 10^11 too small (CloudMicrophysics' own test suite fails onmainwith 1.3.3). CloudMicrophysics 0.46.0, with the updated kernels andClimaParams = "1.3.3"compat (CliMA/CloudMicrophysics.jl#814), is being released separately.This caps
ClimaParamsat1.3.2for CloudMicrophysics0.42 - 0.45; the entry's version range was0.42 - 0, which only covers those four released versions today.