Skip to content

Return practical integer reading times - #6

Merged
Jord-JD merged 3 commits into
masterfrom
agent/2026-package-maintenance
Jul 17, 2026
Merged

Return practical integer reading times#6
Jord-JD merged 3 commits into
masterfrom
agent/2026-package-maintenance

Conversation

@Jord-JD

@Jord-JD Jord-JD commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • returns rounded-up integer minutes and seconds suitable for display
  • adds scalar parameter and return types
  • rejects zero or negative reading speeds instead of dividing by zero
  • updates tests and adds PHP 7.1/PHP 8.5 CI
  • moves the branch alias to 4.0 because the return-type change is intentionally breaking

Why

This resolves #2 and #3 and supersedes #5. A major release is planned because callers may currently depend on fractional values.

Validation

  • Composer JSON parsed successfully
  • git diff --check passed
  • GitHub Actions runs the updated unit suite on the supported floor and PHP 8.5

@Jord-JD
Jord-JD merged commit e508f7e into master Jul 17, 2026
6 checks passed
@Jord-JD
Jord-JD deleted the agent/2026-package-maintenance branch July 17, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add type hints or annotation comment

1 participant