Skip to content

Fix for applying the ip address pool range in k3s lite script - #95

Closed
theycallmeloki wants to merge 9 commits into
JamesTurland:mainfrom
theycallmeloki:main
Closed

theycallmeloki wants to merge 9 commits into
JamesTurland:mainfrom
theycallmeloki:main

Conversation

@theycallmeloki

@theycallmeloki theycallmeloki commented Jul 17, 2024 •

Copy link
Copy Markdown

Greetings! huge fan!

When running it in a fully automated way I noticed the pods for the load balancer were stuck in pending and noticed it wasn't being applied even though it was being created, this patch applies the same

I wasn't sure about the $HOME/ipAddress bit as I am not sure I handled that correctly

Thanks!

@JamesTurland

Copy link
Copy Markdown
Owner

Thank you for this detailed commit, looks comprehensive. I will test once I have a chance.

@DefNotJeffrey

Copy link
Copy Markdown
Collaborator

Closing. This bakes environment-specific values into the shared script (personal IPs, usernames, passwords, Grafana credentials), so it is not mergeable as is. The script overhaul direction for this repo is the one taken in #170. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants