Tie the external reaction and buoyancy properties only once - #1491
Tie the external reaction and buoyancy properties only once#1491Zaretto wants to merge 1 commit into
Conversation
FGExternalReactions::Load() and FGBuoyantForces::Load() are public and append to their force and cell lists, so either may be called more than once to add further items. My specific use case for this that an aircraft declares in <external_reactions> or <buoyant_forces> but then I need to add external forces from the C++ side which causes harmless errors because a second bind would log errors on the tied properties.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1491 +/- ##
==========================================
- Coverage 25.06% 25.05% -0.01%
==========================================
Files 171 171
Lines 18842 18845 +3
==========================================
Hits 4722 4722
- Misses 14120 14123 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Hmm, although the So in terms of adding additional external forces etc. later on via your C++ host are you building up XML elements in your C++ host and then passing that in to the So I wonder if it wouldn't be better to rather add additional methods that allow C++ hosts to add additional external forces/moments etc.? |
2 participants
FGExternalReactions::Load() and FGBuoyantForces::Load() are public and append to their force and cell lists, so either may be called more than once to add further items.
My specific use case for this that an aircraft declares in <external_reactions> or <buoyant_forces> but then I need to add external forces from the C++ side which causes harmless errors because a second bind would log errors on the tied properties.