Bump Injective test tube to v1.20.0 #64
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ fn main() { | |
| .join("artifacts") | ||
| .join("libinjectivetesttube.docrs.h") | ||
| } else { | ||
| out_dir.join(format!("lib{lib_name}.h")) | ||
|
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check for MSRV declarations in project Cargo.toml files
echo "=== Checking for explicit MSRV declarations ==="
fd -t f -name "Cargo.toml" -path "*/packages/*" | xargs grep -H "rust-version" || echo "No explicit rust-version field found"
echo ""
echo "=== Checking for rust-toolchain files ==="
fd -t f -name "rust-toolchain*" || echo "No rust-toolchain files found"
echo ""
echo "=== Checking workspace Cargo.toml ==="
if [ -f "Cargo.toml" ]; then grep -A 5 "\[workspace\]" Cargo.toml | grep -i "rust\|version" || echo "No workspace-level MSRV"; fiRepository: InjectiveLabs/test-tube Length of output: 768 🏁 Script executed: #!/bin/bash
# Verify the inline format syntax patterns in all four files
echo "=== File 1: packages/injective-test-tube/build.rs (line 19) ==="
sed -n '15,25p' packages/injective-test-tube/build.rs
echo ""
echo "=== File 2: packages/test-tube/src/runner/app.rs (line 384) ==="
sed -n '380,390p' packages/test-tube/src/runner/app.rs
echo ""
echo "=== File 3: packages/test-tube/src/runner/result.rs (line 242) ==="
sed -n '238,248p' packages/test-tube/src/runner/result.rs
echo ""
echo "=== File 4: packages/injective-test-tube/src/module/auction.rs (line 104) ==="
sed -n '100,110p' packages/injective-test-tube/src/module/auction.rs
echo ""
echo "=== Checking root Cargo.toml for package-level MSRV ==="
head -30 Cargo.toml | grep -E "rust|version"Repository: InjectiveLabs/test-tube Length of output: 2034 🌐 Web query:
💡 Result: Rust's support for implicit named arguments within format strings (often referred to colloquially as "inline format strings" or f-string-like syntax, such as format!("Hello, {name}")) was stabilized in Rust 1.58.0, released on January 13, 2022 [1][2]. Prior to this version, developers were required to explicitly bind variables if they wanted to use them by name, such as format!("Hello, {name}", name = name). The introduction of this feature allows the macro to implicitly capture local variables with the same name as the identifier provided in the curly braces [3][2]. It is important to note that these are not true "f-strings" in the sense of some other programming languages (which often evaluate arbitrary expressions within the string at runtime). In Rust, the format string must still be a string literal, and the macro operates at compile-time to validate the format string against the provided arguments [4][1]. The feature simply provides syntactic sugar to reduce boilerplate when capturing local variables [3][2]. Subsequent compiler improvements, such as the one implemented in Rust 1.67, further optimized this system by allowing the compiler to flatten or inline literal arguments into the format string during compilation, which can improve performance and help with certain macro-related optimizations [5][6]. Citations:
Declare project MSRV to match Rust 1.58.0+ requirement for inline format syntax. All four affected files use Rust's inline format string syntax ( Affected files:
📍 Affects 4 files
🤖 Prompt for AI Agents |
||
| }; | ||
| // rerun when go code is updated | ||
| emit_rerun_if_changed(&manifest_dir.join("libinjectivetesttube")); | ||
|
|
@@ -67,7 +67,7 @@ fn main() { | |
|
|
||
| // disable linking if docrs | ||
| if std::env::var("DOCS_RS").is_err() { | ||
| println!("cargo:rustc-link-lib=dylib={lib_name}"); | ||
| } | ||
|
|
||
| // The bindgen::Builder is the main entry point | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why path addition? better to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch