Fix/eap feedback improvement - #2462
Open
crsstha wants to merge 7 commits into
Open
Conversation
|
crsstha
force-pushed
the
fix/eap-feedback-improvement
branch
2 times, most recently
from
August 3, 2026 07:51
20a8ca1 to
79247f3
Compare
crsstha
marked this pull request as draft
August 5, 2026 05:27
crsstha
force-pushed
the
fix/eap-feedback-improvement
branch
from
August 6, 2026 08:38
334394b to
cd85ed2
Compare
crsstha
marked this pull request as ready for review
August 6, 2026 08:43
AmritBhusal
reviewed
Aug 6, 2026
Comment on lines
+213
to
+232
| {!withoutTimeframeSelection && ( | ||
| <SelectInput | ||
| label={strings.operationTimeFrameLabel} | ||
| name="timeframe" | ||
| value={value.timeframe} | ||
| onChange={handleTimeframeChange} | ||
| keySelector={timeframeKeySelector} | ||
| labelSelector={stringValueSelector} | ||
| options={eapTimeframeOption} | ||
| disabled={disabled} | ||
| error={error?.timeframe} | ||
| readOnly={readOnly || eapTimeFrameReadOnly} | ||
| hint={isTimeframeFixedToLeadTime | ||
| ? strings.operationTimeFrameLeadTimeHint | ||
| : undefined} | ||
| /> | ||
| )} | ||
| {!withoutTimeframeSelection && value?.timeframe && ( | ||
| <Checklist | ||
| label={strings.operationTimeValueLabel} |
There was a problem hiding this comment.
!withoutTimeframeSelection is checked twice here. We can wrap both SelectInput and Checklist in one condition.
{!withoutTimeframeSelection && ( <> <SelectInput /> {value?.timeframe && <Checklist />} </> )}
AmritBhusal
reviewed
Aug 6, 2026
- Remove National Society, delegation and partner NS contact sections from Full and Simplified overviews - Drop the corresponding contact schema validations - Require National Society contact name, title and email in EAP registration - Point the "send us a message" link to mailto:DREF.anticipatorypillar@ifrc.org - Add header descriptions to operation activity lists - Hide the Admin2 select button instead of disabling it when unavailable - Update EAP form labels and descriptions
- rename *_images fields to *_files, people_targeted to total_people_targeted, and operational_timeframe to activation_timeframe - replace key actor national society select with free-text partner input - add National Society contact section and RCRC Climate Center checkbox - drop IFRC delegation, head of delegation and global ops coordinator contacts - replace Pending PFA status with Approved / Project Agreement Signed
- Add Activation 1 / Activation 2 checklist to prepositioning and early action activities, and render it in the full and summary exports - Add a disaster sub-type input to EAP registration, shown for epidemic and other disaster types, and show it read-only on the Full and sEAP overviews - Make the trigger model timeframe selectable again
frozenhelium
force-pushed
the
fix/eap-feedback-improvement
branch
from
August 7, 2026 09:38
77d3d89 to
fa75dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
https://github.com/toggle-corp/togglecorp-meta/issues/2179
This PR Ensures:
console.logstatements meant for debugging