Repository navigation
Show the scrollbar of result formulas wider than the screen - #5
Merged
Merged
Conversation
On a phone the L and U of a 5x5 LU, and wide result checks, were cut at the right edge with nothing to say that they scroll: Flutter draws no scrollbar for a horizontal scroll view. Result formulas and checks now show one, and reserve room for the thumb only while they overflow, so a formula that fits keeps its spacing. With a mouse, dragging the thumb is also the way to reach the hidden part.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a phone, the L and U of a 5×5 LU result (and wide result checks such as L·U = A with large entries) were cut at the right edge. They could be scrolled by swiping or Shift+wheel, but nothing showed that more was there: Flutter draws no scrollbar for a horizontal scroll view, and a matrix cut at the edge looks complete. Found in the live-site check at 390 px.
Change
SidewaysFormula(insolution_summary.dart) wraps each result part and each result check: a horizontal scroll view with an always-visible scrollbar, like the matrix grid's.docs/DESIGN_SYSTEM.mdrecords the rule.Verification
test/result_scrollbar_test.dart(4 tests): a phone-width LU result overflows and a mouse drag on the thumb scrolls it; a wide check has the always-visible bar driving its own position; a fitting result keeps zero padding; the padding appears on a phone and goes on a wide window. All four fail without the change.flutter analyze: no issues.flutter test: 501 passed.dart formatcheck over all tracked files: no changes.tool/all_shapes_sweep_test.dart: 63/63 passed.--base-href /matriks/) in Chrome: at 390 px the bar shows under L and U in light and dark, dragging it reveals L's fifth column; at 1440 px a 2×2 LU shows no thumb and unchanged spacing; no console errors.