Repository navigation
Conversation
for more information, see https://pre-commit.ci
Siilwyn
commented
Sep 10, 2026
Comment on lines
+60
to
+65
| impl From<musicbrainz_rs::ApiEndpointError> for ErrorType { | ||
| fn from(err: musicbrainz_rs::ApiEndpointError) -> Self { | ||
| Self::Request(Box::new(err)) | ||
| } | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
Clippy complained about big errors, I couldn't find a better solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 before adding functionality for #190 I thought it'd be good to get a bit more familiar with the codebase.
I noticed musicbrainz_rs_nova is used which seems to be an unmaintained fork while the upstream crate is maintained again. So I basically switched to the upstream crate with the rustls so there is no longer an implicit SSL system dependency.
I'm quite new to Rust so I'm not sure about all changes.
Besides that I found the the upstream crate outputs the year as a string and a new
idis expected so I updated the JSON. (00000000-0000-0000-0000-000000000000)Let me know what you think.