Repository navigation
Fix critical bugs, CORS issues, and remove unused files - #192
Merged
Merged
Conversation
majdjadalhaq
requested review from
Dalia-Saeed,
Hadidreem17 and
hkarimx
and removed request for
Copilot
March 9, 2026 19:10
Hadidreem17
approved these changes
Mar 9, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
The live site (c54b.hyf.dev) was missing from the CORS list, so API calls and Socket.io notifications didn't work in production. Now both use one shared list.
The "Message Seller" button on a listing page was building the wrong chat URL. This broke the whole review flow — the seller couldn't see the buyer in the "Mark as Sold" list, so the buyer never got the option to leave a review. Fixed.
The map on the listing creation form (drag pin) would crash because it was importing from a file we removed. Fixed.
/inbox and /chat pages were accessible without being logged in. They are now protected.
dotenv was loading after other imports, which could cause environment variables to be undefined at startup. Moved to the very first line.
The Cypress test seed had the admin email and password written directly in the code. Moved to environment variables.
Dead code removed:
Old ResetPassword.jsx page — was never connected to any route. The forgot password flow already handles everything inside ForgotPassword.jsx.
Old VerifyCode.jsx in the wrong folder — the real one lives in pages/User/.
Two import shim files for the map component that nobody was using anymore.
18 Cypress example files that came with the framework and were never part of our tests.
Other:
Added 7 missing variables to .env.example so new developers know what to set up.