Remove usage of proc_pidinfo on iOS#1679
Merged
Merged
Conversation
This is not present in the headers in the iOS SDK, so using it is disallowed by Apple's App Store review guidelines: https://developer.apple.com/app-store/review/guidelines/#software-requirements:~:text=Apps%20may%20only%20use%20public%20APIs (And yes, they do tend to read that sentence to the letter, even if they may sometimes grant apps exceptions to it). (I have also filed FB23247918 to ask them for clarification, because the symbols are marked `__OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0)` in the macOS SDK's header).
50445c6 to
680e14b
Compare
GuillaumeGomez
approved these changes
Jun 18, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not present in the headers in the iOS SDK, so using it is disallowed by Apple's App Store review guidelines.
(And yes, they do tend to read that sentence to the letter, even if they may sometimes grant apps exceptions to it).
I have also filed FB23247918 to ask them for clarification, because the symbols are marked
__OSX_AVAILABLE_STARTING(__MAC_10_5, __IPHONE_2_0)in the macOS SDK's header, though I don't think we should block on this, there are other places insysinfowhere we useproc_pidinfothat could benefit from being usable on iOS but that can be re-introduced later once we know more.This should make
sysinfocompile on iOS with rust-lang/libc#5158.I did also take a look, it seems that #424 removed usage of
proc_pidinfoin the past, so doing this forPROC_PIDLISTFDSas well is consistent with that.