Skip to content

refactor[cartesian]: skip LiftTrivalIf in sdfg.simplify() pipeline #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlorianDeconinck merged 1 commit into from
Jul 28, 2026
+10 −6
Merged

refactor[cartesian]: skip LiftTrivalIf in sdfg.simplify() pipeline #2710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/gt4py/cartesian/backend/dace_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,11 @@ def sdfg_via_schedule_tree(self, *, validate: bool = False, simplify: bool = Tru
sdfg = stree.as_sdfg(
validate=validate,
simplify=simplify,
skip={"ScalarToSymbolPromotion", "ControlFlowRaising"},
# We skip
# - `ScalarToSymbolPromotion` because we've seen validation issue in the past
# - `ControlFlowRaising` because we already generate CFGs in stree -> SDFG
# - `LiftTrivialIf` because it's dead slow (e.g. fv3 acoustics parsing takes >90min compared to 10-15min without)
skip={"ScalarToSymbolPromotion", "ControlFlowRaising", "LiftTrivialIf"},
)

if do_cache:
Expand Down Expand Up @@ -485,11 +489,11 @@ def __call__(self) -> dict[str, dict[str, str]]:
manager = SDFGManager(self.backend.builder)

sdfg = manager.sdfg_via_schedule_tree()
_specialize_transient_strides(
sdfg,
self.backend.storage_info,
)
sdfg.simplify(validate=True, skip={"ScalarToSymbolPromotion"})
_specialize_transient_strides(sdfg, self.backend.storage_info)
# We skip
# - `ScalarToSymbolPromotion` because we've seen validation issues in the past
# - `LiftTrivialIf` because it's dead slow (e.g. fv3 acoustics parsing takes >90min compared to 10-15min without)
sdfg.simplify(validate=True, skip={"ScalarToSymbolPromotion", "LiftTrivialIf"})

# NOTE
# The glue code in DaCeComputationCodegen.apply() (just below) will define all the
Expand Down