Skip to content

fix[cartesian]: actually freeze origin & domain in K-axis #2684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanc merged 1 commit into from
Jul 8, 2026
Merged

fix[cartesian]: actually freeze origin & domain in K-axis #2684

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions src/gt4py/cartesian/backend/dace_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ def _sdfg_add_arrays_and_edges(
inputs: set[str] | dict[str, dtypes.typeclass],
outputs: set[str] | dict[str, dtypes.typeclass],
origins: dict[str, tuple[int, ...]],
domain: tuple[int, ...],
) -> None:
for name, array in inner_sdfg.arrays.items():
if array.transient:
Expand Down Expand Up @@ -129,12 +130,20 @@ def _sdfg_add_arrays_and_edges(
if axis not in axes:
continue
o = origin[index]
e = field_info[name].boundary.lower_indices[cartesian_index]
lower, upper = field_info[name].boundary[cartesian_index]
s = inner_sdfg.arrays[name].shape[index]
ranges.append(
# s - 1 because ranges are inclusive
(o - max(0, e), o - max(0, e) + s - 1, 1)
)
if axis == CartesianSpace.Axis.K.name:
d = domain[cartesian_index]
ranges.append(
# max(0, lower) because ...
# d - 1 because ranges are inclusive
(o - max(0, lower), o + upper + d - 1, 1)
)
else:
ranges.append(
# s - 1 because ranges are inclusive
(o - max(0, lower), o - max(0, lower) + s - 1, 1)
)
index += 1

# Add data dimensions to the range
Expand Down Expand Up @@ -264,7 +273,7 @@ def freeze_origin_domain_sdfg(
nsdfg = state.add_nested_sdfg(inner_sdfg, inputs, outputs)

_sdfg_add_arrays_and_edges(
field_info, wrapper_sdfg, state, inner_sdfg, nsdfg, inputs, outputs, origin
field_info, wrapper_sdfg, state, inner_sdfg, nsdfg, inputs, outputs, origin, domain
)

# in special case of empty domain, remove entire SDFG.
Expand Down