[WIP] Bump HBase to 2.1.10 - #3
Draft
nvtkaszpir wants to merge 3 commits into
Draft
Conversation
nvtkaszpir
marked this pull request as draft
April 27, 2020 08:54
cgiraldo
reviewed
Apr 27, 2020
| @@ -1,9 +1,9 @@ | |||
| FROM gradiant/hadoop-base:2.7.7 as hadoop | |||
| FROM quay.io/kaszpir/dockerized-hadoop:3.1.3 as hadoop | |||
Member
There was a problem hiding this comment.
We must not hardcode an external registry in the Dockerfile.
We can use docker build args for that:
ARG hadoop_image="gradiant/hdfs:3.1.2"
FROM $hadoop_image as hadoop
...
Then just set hadoop_image variable in your build environment (for example):
docker build -t quay.io/kaszpir/hbse:2.1.10 --build-arg hadoop_image=quay.io/kaszpir/dockerized-hadoop:3.1.3 .
Also if you need hadoop 3.1.x versions, we have created dockerhub gradiant/hdfs repo with 2.7.7, 2.9.2, 3.1.2 and 3.2.1 images from current gradiant/dockerized-hadoop.
Author
There was a problem hiding this comment.
yeah I know, that's why it's WIP/Draft.
I'm experimenting with some other options, but ARG looks the best.
Was trying to avoid any external Makefiles and so on because I wanted to use ofifical quay.io building image feature from Dockerfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.1.10 is minimal maintained HBase version.
Also had to add HADOOP_VERSION because COPY --from was not following symlink. (another option is to try with hardlinks)