Repository navigation
Conversation
…a one-byte array they hit an unmapped page on Windows
…e options test; it named three and exercised two
…oded uncached; the one entry it had was killed by four older tests without the new legs
…the three decorator entries were killed by older tests as well
…the options test; forwarding only cache and boundscheck kept the suite green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_jit_options_reach_the_is_null_decoratorsfailed on the Windows cell of main after #12 went in (job) and passed when it was re-run. The child that runs without bounds checking exited 0xC0000005, an access violation.The script built a one-byte bitmap and asked for bit 100000, so without bounds checking
is_nullandunpack_booleansread 12.5 KB past the array, and the test asserted that they returned. What lies behind a one-byte array is the allocator's business. It was readable in 86 of the 87 Windows jobs that have run the test, here and on my fork.Now the bitmap is the first byte of an array that holds every byte the calls reach. With bounds checking on both calls still raise
IndexError, the check being against the bitmap's one byte. With it off they read memory the array owns. The test still fails when the options stop reaching the decorators inis_null.py, and the crash reproduces on Linux with the bitmap on the last byte of a page and unreadable pages behind it.The test's comment named all three of
is_null.py's decorators and its script exercised two, and of the options it observed only the two that show. It now checks the cache option on each of the three, off and on, and readsnogil, which shows on none of them, back from the three dispatchers. The catalogue has an entry per decorator, each hard-coded uncached, and two more that only the new legs catch: the cache option dropped forunpack_booleansalone, and every option but cache and boundscheck dropped.