This repository was archived by the owner on Jan 13, 2023. It is now read-only.

This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Chapter 2 embeddings last cell - change request #22

Open

opened

on Feb 12, 2021

Dear authors,

The last cell of the notebook could be confusing : indeed, when using pre-trained embedding vectors, it is not useful to have EMBED_DIM parameter defined. The build_hub_model() method does not use it hopefully :)

Best regards
Jerome

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

No labels

No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests