Skip to content

Support Resource Manager tags on Cloud Run v2 Service and Job creation#18196

Open
kminsu-google wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
kminsu-google:support-tags-on-creation
Open

Support Resource Manager tags on Cloud Run v2 Service and Job creation#18196
kminsu-google wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
kminsu-google:support-tags-on-creation

Conversation

@kminsu-google

Copy link
Copy Markdown
Member

Summary

  • add tags support for Cloud Run v2 Service and Job creation
  • add acceptance tests for service/job tag creation and import behavior
  • add example configurations for the new tags field

Release Note

cloudrunv2: added `tags` field to `google_cloud_run_v2_service` and `google_cloud_run_v2_job` resources to allow setting tags for services and jobs at creation time.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 6, 2026
@kminsu-google kminsu-google force-pushed the support-tags-on-creation branch from 0e8e63a to 0933b56 Compare July 7, 2026 00:23
@kminsu-google kminsu-google marked this pull request as ready for review July 7, 2026 03:48
@github-actions github-actions Bot requested a review from ScottSuarez July 7, 2026 03:49
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@kminsu-google

Copy link
Copy Markdown
Member Author

@avianap can you take a look

@modular-magician modular-magician added service/run and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 7, 2026
@modular-magician

modular-magician commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f8a26be:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 222 insertions(+), 24 deletions(-)
google-beta provider View Diff 10 files changed, 226 insertions(+), 28 deletions(-)
terraform-google-conversion View Diff 2 files changed, 34 insertions(+)

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • cloudrunv2

Please fix the compilation errors to complete your PR.

View the build log

@kminsu-google, @ScottSuarez, @qwerjkl112 VCR tests complete for f8a26be!

@kminsu-google

Copy link
Copy Markdown
Member Author

Working on a VCR-test build failure

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 7, 2026
@modular-magician

modular-magician commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0f4b889:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 230 insertions(+), 24 deletions(-)
google-beta provider View Diff 10 files changed, 234 insertions(+), 28 deletions(-)
terraform-google-conversion View Diff 2 files changed, 34 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
92 81 9 2
Affected Service Packages
  • cloudrunv2

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCloudRunV2Job_cloudrunv2JobWithTags
  • TestAccCloudRunV2Service_cloudrunv2ServiceWithTags

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCloudRunV2Job_cloudrunv2JobWithTags
✅ Log TestAccCloudRunV2Service_cloudrunv2ServiceWithTags

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@kminsu-google, @ScottSuarez, @qwerjkl112 VCR tests complete for 0f4b889!

@ScottSuarez ScottSuarez added this pull request to the merge queue Jul 7, 2026
@ScottSuarez ScottSuarez removed this pull request from the merge queue due to a manual request Jul 7, 2026
@ScottSuarez

Copy link
Copy Markdown
Contributor

waiting for other reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants