Skip to content

Fallback to async timeouts if top level timeouts are not specified#18190

Open
SirGitsalot wants to merge 2 commits into
mainfrom
issue-28175
Open

Fallback to async timeouts if top level timeouts are not specified#18190
SirGitsalot wants to merge 2 commits into
mainfrom
issue-28175

Conversation

@SirGitsalot

@SirGitsalot SirGitsalot commented Jul 6, 2026

Copy link
Copy Markdown
Member

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

gemini: fixed truncated timeouts in `google_gemini_code_tools_setting`, `google_gemini_data_sharing_with_google_setting_binding`, `google_gemini_gemini_gcp_enablement_setting_binding`, and `google_gemini_release_channel_setting_binding`
observability: fixed unintentionally long timeouts in `google_observability_folder_settings`, `google_observability_organization_settings`, and `google_observability_project_settings`
oracledatabase: fixed truncated timeouts in `google_oracle_database_exadb_vm_cluster`, `google_oracle_database_goldengate_connection`, and `google_oracle_database_odb_subnet`

Fixes hashicorp/terraform-provider-google#28175

@modular-magician

modular-magician commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e9a1866:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 17 files changed, 48 insertions(+), 48 deletions(-)
google-beta provider View Diff 20 files changed, 54 insertions(+), 54 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
85 83 2 0
Affected Service Packages
  • gemini
  • observability
  • oracledatabase

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@SirGitsalot VCR tests complete for e9a1866!

@modular-magician

modular-magician commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 20d8b29:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 17 files changed, 48 insertions(+), 48 deletions(-)
google-beta provider View Diff 20 files changed, 54 insertions(+), 54 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
85 83 2 0
Affected Service Packages
  • observability
  • oracledatabase
  • gemini

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@SirGitsalot VCR tests complete for 20d8b29!

@SirGitsalot

Copy link
Copy Markdown
Member Author

Fixes hashicorp/terraform-provider-google#28202 too, assuming that the workaround PR (hashicorp/terraform-provider-google#28202) is not submitted first.

@SirGitsalot

Copy link
Copy Markdown
Member Author

The YAML changes were needed because all timeouts must be specified, e.g.,:

    timeouts:
      insert_minutes: 10
      update_minutes: 10

Results in:

    Timeouts: &schema.ResourceTimeout{
      Create: schema.DefaultTimeout(10 * time.Minute),
      Update: schema.DefaultTimeout(10 * time.Minute),
      Delete: schema.DefaultTimeout(0 * time.Minute),
    },

This was true before, but because of the bug the operations timeouts were ignored so the affected resources were getting all three default timeouts instead.

@SirGitsalot

Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from ScottSuarez July 7, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async timeouts not honored

2 participants