Fallback to async timeouts if top level timeouts are not specified#18190
Fallback to async timeouts if top level timeouts are not specified#18190SirGitsalot wants to merge 2 commits into
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e9a1866: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @SirGitsalot VCR tests complete for e9a1866! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 20d8b29: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @SirGitsalot VCR tests complete for 20d8b29! |
|
Fixes hashicorp/terraform-provider-google#28202 too, assuming that the workaround PR (hashicorp/terraform-provider-google#28202) is not submitted first. |
|
The YAML changes were needed because all timeouts must be specified, e.g.,: Results in: This was true before, but because of the bug the operations timeouts were ignored so the affected resources were getting all three default timeouts instead. |
|
@modular-magician reassign-reviewer |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Fixes hashicorp/terraform-provider-google#28175