bigqueryreservation: add principal field to ReservationAssignment#18189
Open
fuzmish wants to merge 1 commit into
Open
bigqueryreservation: add principal field to ReservationAssignment#18189fuzmish wants to merge 1 commit into
fuzmish wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
42b5d41 to
9f8e835
Compare
9f8e835 to
07807ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is a re-submission of #17080, which was closed without merge.
The purpose is to support User-specific assignments by adding the
principalfield togoogle_bigquery_reservation_assignment. As of June 30, 2026, the feature has been officially released as Public Preview, and the field is now explicitly present in the v1 REST API discovery document. Based on this, we have set this to GA field (notmin_version: beta).Changes:
principalfield toReservationAssignmentresource. Description is taken verbatim from the v1 discovery document.bigquery_reservation_assignment_full_with_principal(with corresponding test) to cover theprincipalfield. A separate example is used rather than modifying the existing_fullexample, asprincipal-based assignment is a distinct usage pattern.Testing
The provider was built locally from this branch and tested with
dev_overrides. Resource creation withprincipalset to a service account principal was verified to succeed end-to-end.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.