sql: add include_replicas_for_major_version_upgrade to google_sql_database_instance#18172
Conversation
modular-magician
added
the
awaiting-approval
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
DrFaust92
force-pushed
the
sql-include-replicas-major-version-upgrade
branch
from
dc5ea4f to
81f3312
Compare
…abase_instance Adds the input-only `include_replicas_for_major_version_upgrade` field to `google_sql_database_instance`. When set to true, an in-place major version upgrade of the primary (via a `database_version` change) also upgrades its read replicas in place. The field is passed on the atomic database_version patch, matching the Cloud SQL Admin API's input-only semantics.
DrFaust92
force-pushed
the
sql-include-replicas-major-version-upgrade
branch
from
81f3312 to
d4aafc4
Compare
|
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
|
@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label |
2 participants
Adds the input-only
include_replicas_for_major_version_upgradefield togoogle_sql_database_instance.When set to
true, an in-place major version upgrade of the primary instance (triggered by adatabase_versionchange) also upgrades its read replicas in place. The field is input-only in the Cloud SQL Admin API and is sent on the atomicdatabase_versionpatch during update.Test
Added
TestAccSqlDatabaseInstance_includeReplicasForMajorVersionUpgrade, which creates a MySQL 8.0 primary + read replica on a private network, then upgrades the primary to 8.4 with the flag enabled (the replica ignoresdatabase_versiondrift so the server-side cascade isn't raced). Passing locally: