feat: Support --universe-domain CLI flag for TPC environments - #968
Merged
Merged
Conversation
Introduces the --universe-domain flag for configuring sovereign cloud and TPC universe domains. Enforces mutual exclusivity with --alloydbadmin-api-endpoint and propagates configuration to the AlloyDB connector dialer and IAM service account impersonation sources.
enocom
reviewed
Aug 31, 2026
enocom
left a comment
enocom
left a comment
Member
There was a problem hiding this comment.
LGTM.
Do we want to add support for the GOOGLE_UNIVERSE_DOMAIN env-var here?
Contributor
Author
I wasn't planning to support that env var, as CSQL proxy does not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the --universe-domain flag for configuring sovereign cloud and TPC universe domains. Enforces mutual exclusivity with --alloydbadmin-api-endpoint and propagates configuration to the AlloyDB connector dialer and IAM service account impersonation sources.