Skip to content

[upstream PR #310] Integration blocked: fix: examples in kalman_filter.py #107

Description

@GeorgePearse

Upstream PR: rlabbe/filterpy#310
Issue Type: Cherry-pick failed: fatal: bad object 44f5178610b22fa0ed1574e50540c8c281780748


Problem

Error: Cherry-pick failed: fatal: bad object 44f5178610b22fa0ed1574e50540c8c281780748


Original Description

The code in the Kalman filter example was broken in multiple ways. There were syntax errors, array shape errors, and undefined name errors.

I think I've fixed them in a reasonable way. I've also added a seeded random number generator to make the example deterministic. The only thing I'm not sure about is when I define dt = 1 as a constant, and if cv is the best name for the KalmanFilter instance in this example. Perhaps f is better. Please advise.

I'll also note that perhaps some of these examples might be better written as a doctest. The standard library doctest runner can be a bit annoying, but my xdoctest library works very well and would help ensure that all of the examples actually run.

I can convert this particular example if desired. Let me know.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    upstream-pr-blockedUpstream PR blocked by conflicts or errors

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions