Drop support for CVC4 - #1766
Open
RyanGlScott wants to merge 2 commits into
Open
Conversation
langston-barrett
approved these changes
Mar 5, 2026
langston-barrett
left a comment
langston-barrett
left a comment
Contributor
There was a problem hiding this comment.
LGTM, perhaps worth a CHANGELOG entry for all of these packages?
This drops support for CVC4 in the `crucible` and `crux` libraries, as well as in the `crux-llvm` test suite. It also replaces references to CVC4 in the documentation with references to CVC5. See GaloisInc/what4-solvers#57 for the motivation.
RyanGlScott
force-pushed
the
crux-drop-cvc4
branch
from
March 5, 2026 16:43
8be50b6 to
8e8da93
Compare
Contributor
Author
|
Ah yes, silly me. I've amended the changelogs for the |
sauclovian-g
approved these changes
Mar 5, 2026
Contributor
|
What's the status of this PR? Should we go ahead and merge it? |
Contributor
|
It's blocked on GaloisInc/saw-script#2976, which is blocked on SAW's deprecation schedule. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops support for CVC4 in the
crucibleandcruxlibraries, as well as in thecrux-llvmtest suite. It also replaces references to CVC4 in the documentation with references to CVC5.See GaloisInc/what4-solvers#57 for the motivation.