Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions python/GafferUI/ShowURL.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ def showURL( url ) :
# yet has no problem with opening the file itself. This
# means we can't support anchors in file URLs on Windows
# as we need to strip them to produce a valid file path.
url = url[7:].partition( "#" )[0]
url = QtCore.QUrl.fromLocalFile( url[7:].partition( "#" )[0] )
else :
url = QtCore.QUrl( url, QtCore.QUrl.TolerantMode )

QtGui.QDesktopServices.openUrl( QtCore.QUrl( url, QtCore.QUrl.TolerantMode ) )
QtGui.QDesktopServices.openUrl( url )
65 changes: 65 additions & 0 deletions python/GafferUITest/ShowURLTest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
##########################################################################
#
# Copyright (c) 2026, Pascal Andre. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
# * Redistributions of source code must retain the above
# copyright notice, this list of conditions and the following
# disclaimer.
# * Redistributions in binary form must reproduce the above
# copyright notice, this list of conditions and the following
# disclaimer in the documentation and/or other materials provided with
# the distribution.
# * Neither the name of John Haddon nor the names of
# any other contributors to this software may be used to endorse or
# promote products derived from this software without specific prior
# written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
# IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
# CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
# EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
# PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
# OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
# OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
# ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#
##########################################################################

import sys
import unittest
import unittest.mock

import GafferUI
import GafferUITest

from Qt import QtGui


class ShowURLTest( GafferUITest.TestCase ) :

def testWebURL( self ) :

with unittest.mock.patch.object( QtGui.QDesktopServices, "openUrl" ) as openURL :
GafferUI.showURL( "https://www.gafferhq.org" )

openURL.assert_called_once()
self.assertEqual( openURL.call_args[0][0].toString(), "https://www.gafferhq.org" )

@unittest.skipUnless( sys.platform == "win32", "Windows-specific URL handling" )
def testLocalFileURL( self ) :

path = "C:/Program Files/Gaffer/doc/gaffer/html/index.html"
with unittest.mock.patch.object( QtGui.QDesktopServices, "openUrl" ) as openURL :
GafferUI.showURL( "file://" + path + "#section" )

openURL.assert_called_once()
url = openURL.call_args[0][0]
self.assertTrue( url.isLocalFile() )
self.assertEqual( url.toLocalFile().replace( "\\", "/" ), path )
1 change: 1 addition & 0 deletions python/GafferUITest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
from .AuxiliaryConnectionsGadgetTest import AuxiliaryConnectionsGadgetTest
from .MessageWidgetTest import MessageWidgetTest
from .ModuleTest import ModuleTest
from .ShowURLTest import ShowURLTest
from .PlugLayoutTest import PlugLayoutTest
from .ViewportGadgetTest import ViewportGadgetTest
from .VectorDataWidgetTest import VectorDataWidgetTest
Expand Down