MEC dial updates#51
Open
sjgardiner wants to merge 27 commits into
Open
Conversation
…parameter implementation
src/RwCalculators/GReWeightINuke.h
…enabled actual reweighting to the 2p-2h Martini model by inputting MartiniEricsonChanfrayMarteauMECPXSec2024 into placeholder for XSecShape_CCMEC_Martini dial
…onsidering the 2p2h Martini model and added normalsation for DecayAngMEC parameter with two tweak dials
…cia model and the energy transfer cut-off in the Martini model
…will be handled automatically in the code.
…ecShape_CCMEC and XSecShape_CCMEC_Martini dials
…Martini-Ericson_Chanfray-Marteau model is input as default
…n GReWeightXSecMEC.cxx
…ied instead of divided (input default model gets up- or down-reweighted according to renormalised cross section ratio being greater or smaller to 1.)
…ng hard-coded xsec ratio tables to it reading the xsecs directly from the user's input cross-section spline xml-file. The user can now input multiple xml-files via the cross-sections option of grwght1p.
…RwghtNCorrelatedParams.cxx (matches original implementation)
sjgardiner
force-pushed
the
feature/mec-dial-updates
branch
from
July 15, 2026 15:57
0de7241 to
855182e
Compare
…s may be supplied via the --cross-sections command-line option
special "Reweight" configuration of the empirical MEC xsec algorithm
sjgardiner
force-pushed
the
feature/mec-dial-updates
branch
from
July 15, 2026 17:25
a6bf5e9 to
5361df0
Compare
Member
Author
|
This is mostly in good shape but still needs some attention. I note that the reweighting of Valencia CCMEC events that involve an internal Δ line vs. those that do not appears to be broken by these changes. I will have a look at restoring that functionality and double-checking everything else. |
sjgardiner
force-pushed
the
feature/mec-dial-updates
branch
from
July 16, 2026 16:12
5e0bbfa to
768e6ed
Compare
…n in favor of adapting the existing GetXSecIntegral member function to be more general.
sjgardiner
force-pushed
the
feature/mec-dial-updates
branch
from
July 16, 2026 22:23
768e6ed to
d50764c
Compare
…ns to the CC MEC cross section under the Valencia model. This functionality was removed when implementing pn-fraction reweighting for the SuSAv2 and Martini MEC models. It now lives in a separate member function of GReWeightXSecMEC. For models other than Valencia, the new function simply returns a unit weight.
Member
Author
|
The "Δ / no Δ" reweighting for the Valencia model is now fixed on some new commits. I moved the relevant code into a dedicated member function to make the implementation cleaner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for PR #49 that has been rebased onto
masterand cleaned up. Contributions originally developed by Lars Bathe-Peters (@larsb-p).Updated list of 2p2h/MEC uncertainties handled by Reweight:
Input CCMEC models that are compatible with the updated dials include Valencia, SuSAv2, and Martini-Ericson-Chanfray-Marteau.