Repository navigation
Fix the shaka-player CSS font patch not being applied - #9839
Merged
FreeTubeBot merged 1 commit intoSep 27, 2026
Merged
Conversation
FreeTubeBot
enabled auto-merge (squash)
September 24, 2026 21:28
github-actions
Bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Sep 25, 2026
PikachuEXE
left a comment
PikachuEXE
left a comment
Member
There was a problem hiding this comment.
Might be good to run pnpm run clean first to avoid being confused on which file to check
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 25, 2026
radmorecameron
approved these changes
Sep 27, 2026
github-actions
Bot
removed
the
PR: waiting for review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
Because pnpm places the hardlinks from the global store to node_modules in
node_modules/.pnpminstead of directly intonode_modulesand then symlinks the direct dependencies that are listed in thepackage.jsonfile intonode_modulesand symlinks are resolved as part of module resolution (hardlinks aren't), webpack was using thenode_modules/.pnpm/shaka-player@versionpath so it never matched the path configured in the rule. This pull request switches torequire.resolverather than manually constructing the path to fix that issue. Without the patch shaka-player links to the Roboto font on Google Fonts.Testing
pnpm run pack:rendererdist/renderer.*.cssfile only contains a single Roboto@font-facedeclaration that points to the bundled font.pnpm run pack:webdist/web/web.*.cssfile only contains a single Roboto@font-facedeclaration that points to the bundled font.Desktop