Display different message when comments are turned off - #9752
Open
caetano-dev wants to merge 4 commits into
Open
Display different message when comments are turned off#9752caetano-dev wants to merge 4 commits into
caetano-dev wants to merge 4 commits into
Conversation
caetano-dev
requested review from
PikachuEXE,
absidue and
radmorecameron
as code owners
September 5, 2026 15:58
FreeTubeBot
enabled auto-merge (squash)
September 5, 2026 15:58
Shadorc
reviewed
Sep 5, 2026
Shadorc
reviewed
Sep 5, 2026
Shadorc
reviewed
Sep 6, 2026
Contributor
|
Testing https://www.youtube.com/post/UgkxaotJMxw_9fCQQ7Nc3C1N94IlUty6AxMD with Invidious throws Update: After some investigation, it seems that my invidious instance (latest docker image up to date) returns a completely empty response in this case, while the instance's logs show: So it does not seem to be an issue with this MR, only that this change cannot be reviewed as Invidious does not return a valid response |
Shadorc
previously requested changes
Sep 6, 2026
Shadorc
self-requested a review
September 6, 2026 15:08
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Sep 6, 2026
Shadorc
approved these changes
Sep 6, 2026
1 task
Member
|
I tested https://youtu.be/uPYx12xJFUQ from #5879 and I got error caused by #9620 (comment) I will hold off until that's fixed (in PR at least so I can merge locally |
efb4f5ff-1298-471a-8973-3d47447115dc
dismissed
their stale review
September 7, 2026 20:18
Dismissing in case another Code Owner missed comment above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
closes #9657
Description
Shows a message for when comments are turned off instead of the same message for no comments.
Screenshots
Testing
Desktop