Skip to content

Display different message when comments are turned off - #9752

Open
caetano-dev wants to merge 4 commits into
FreeTubeApp:developmentfrom
caetano-dev:feat/differentiate_no_comments
Open

Display different message when comments are turned off#9752
caetano-dev wants to merge 4 commits into
FreeTubeApp:developmentfrom
caetano-dev:feat/differentiate_no_comments

Conversation

@caetano-dev

@caetano-dev caetano-dev commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Pull Request Type

  • Feature Implementation

Related issue

closes #9657

Description

Shows a message for when comments are turned off instead of the same message for no comments.

Screenshots

image image

Testing

  1. Open https://youtu.be/3uAIqqg8ZHo
  2. Click on the button to load comments
  3. Open https://youtu.be/0GNeqN0sWlc
  4. See that the message is different
  5. Open https://www.youtube.com/post/UgkxaotJMxw_9fCQQ7Nc3C1N94IlUty6AxMD
  6. See it shows the new message for posts as well.

Desktop

  • OS: MacOS
  • OS Version: 27
  • FreeTube version: v0.25.3 Beta

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 5, 2026
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) September 5, 2026 15:58
Comment thread src/renderer/components/CommentSection/CommentSection.vue Outdated
Comment thread src/renderer/components/CommentSection/CommentSection.vue
@Shadorc Shadorc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 5, 2026
@caetano-dev
caetano-dev requested a review from Shadorc September 6, 2026 00:18
Comment thread src/renderer/components/CommentSection/CommentSection.vue
@caetano-dev
caetano-dev requested a review from Shadorc September 6, 2026 13:27
@Shadorc

Shadorc commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Testing https://www.youtube.com/post/UgkxaotJMxw_9fCQQ7Nc3C1N94IlUty6AxMD with Invidious throws
SyntaxError: Failed to execute 'json' on 'Response': Unexpected end of JSON input

Update: After some investigation, it seems that my invidious instance (latest docker image up to date) returns a completely empty response in this case, while the instance's logs show:

[invidious]    |   Exception: Comments not found. (NotFoundException)
[invidious]    |   from /usr/share/crystal/src/json/any.cr:100:10 in 'parse_youtube'
[invidious]    |   from src/invidious/helpers/handlers.cr:31:37 in 'call'
[invidious]    |   from lib/kemal/src/kemal/filter_handler.cr:22:7 in 'call'
[invidious]    |   from /usr/share/crystal/src/http/server/handler.cr:30:7 in 'call'
[invidious]    |   from /usr/share/crystal/src/http/server/handler.cr:30:7 in 'call'
[invidious]    |   from /usr/share/crystal/src/http/server/request_processor.cr:58:11 in 'handle_client'
[invidious]    |   from /usr/share/crystal/src/fiber.cr:170:11 in 'run'
[invidious]    |   from ???

So it does not seem to be an issue with this MR, only that this change cannot be reviewed as Invidious does not return a valid response

Shadorc
Shadorc previously requested changes Sep 6, 2026
@Shadorc
Shadorc self-requested a review September 6, 2026 15:08
@Shadorc
Shadorc dismissed their stale review September 6, 2026 15:09

The bug does not concern this MR

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Sep 6, 2026
@PikachuEXE

Copy link
Copy Markdown
Member

I tested https://youtu.be/uPYx12xJFUQ from #5879 and I got error caused by #9620 (comment)

I will hold off until that's fixed (in PR at least so I can merge locally

@efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc dismissed their stale review September 7, 2026 20:18

Dismissing in case another Code Owner missed comment above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: waiting for review For PRs that are complete, tested, and ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Differentiate videos with comments disabled from videos with no comments

4 participants