Skip to content

Feat: Add a reload button to the player video info bar so you can recover after the player crashes - #9722

Open
mousetail wants to merge 7 commits into
FreeTubeApp:developmentfrom
mousetail:feat/add-reload-button-to-player-page
Open

Feat: Add a reload button to the player video info bar so you can recover after the player crashes#9722
mousetail wants to merge 7 commits into
FreeTubeApp:developmentfrom
mousetail:feat/add-reload-button-to-player-page

Conversation

@mousetail

Copy link
Copy Markdown

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #1005

Description

Currently, sometimes the player gets stuck (session timeout, crash, IP ban, etc.) Right now, the only way to recover from this is to go to your history page, find the video again, then load it. It's not a lot of effort but a bit annoying, especially when the video never actually played so it doesn't show in your history and you need to scroll through the channel page again.

This adds a button next to the share and format options to reload the player.

Screenshots

image

Testing

This is fairly easy to test. Just open a video, and click the new button and see the page reloads.

Desktop

  • **OS: ** Linux
  • OS Version: 7.0.10-1 MANJARO
  • FreeTube version: Development

Additional context

I discussed some thing about this in chat

@github-actions github-actions Bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 31, 2026
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) August 31, 2026 11:06
Comment thread src/renderer/views/Watch/Watch.js
auto-merge was automatically disabled August 31, 2026 11:26

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) August 31, 2026 11:26

@radmorecameron radmorecameron left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested yet, my initial thought is this seems like a good compromise for the hacky "reload" being removed.

Without having tested this, I feel like our debounce function should probably be used for onManualReloadReloadRequested?

export function debounce(func, wait) {

Comment thread src/renderer/views/Watch/Watch.js Outdated
@caetano-dev

Copy link
Copy Markdown
Contributor

Haven't tested yet, my initial thought is this seems like a good compromise for the hacky "reload" being removed.

Without having tested this, I feel like our debounce function should probably be used for onManualReloadReloadRequested?

export function debounce(func, wait) {

Maybe the throttle function would be better, because it executes immediately. debounce has to wait after it is called.

@caetano-dev caetano-dev added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 7, 2026
auto-merge was automatically disabled September 7, 2026 05:13

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) September 7, 2026 05:13
auto-merge was automatically disabled September 7, 2026 05:22

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) September 7, 2026 05:23
@Shadorc Shadorc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Sep 7, 2026
Comment thread src/renderer/views/Watch/Watch.js
@Shadorc

Shadorc commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Now that manually reloading the player is a valid feature, #9552 (comment) should probably be reconsidered?
@efb4f5ff-1298-471a-8973-3d47447115dc

On second thought, it does not seem useful if it is manually triggered

Comment thread static/locales/en-US.yaml Outdated
Published on: Published on
Streamed on: Streamed on
Started streaming on: Started streaming on
Reload Player: Reload Player

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refresh page would probably be a more appropriate name as it refreshed everything except the playlist and comments.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it to Reload Page

auto-merge was automatically disabled September 7, 2026 12:26

Head branch was pushed to by a user without write access

@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) September 7, 2026 12:27
Comment thread src/renderer/components/WatchVideoInfo/WatchVideoInfo.vue Outdated
@caetano-dev caetano-dev added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 7, 2026
caetano-dev
caetano-dev previously approved these changes Sep 7, 2026
@caetano-dev caetano-dev added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Sep 7, 2026
Shadorc
Shadorc previously approved these changes Sep 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 9, 2026
auto-merge was automatically disabled September 9, 2026 11:51

Head branch was pushed to by a user without write access

@mousetail
mousetail dismissed stale reviews from Shadorc and caetano-dev via de7787b September 9, 2026 11:51
@FreeTubeBot
FreeTubeBot enabled auto-merge (squash) September 9, 2026 11:52
@mousetail

Copy link
Copy Markdown
Author

Updated

caetano-dev
caetano-dev previously approved these changes Sep 9, 2026
@caetano-dev caetano-dev added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Sep 9, 2026
@caetano-dev
caetano-dev dismissed their stale review September 9, 2026 12:07

Icon not showing up

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 9, 2026
@Shadorc

Shadorc commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

I get this
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Reload button

6 participants