-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix: "Hide videos from channels" doesn't work for collab videos (local API) #9697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Shadorc
wants to merge
9
commits into
FreeTubeApp:development
Choose a base branch
from
Shadorc:fix/hide-channels-collabs
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7a01f93
Fix hide channel for recommended videos
Shadorc bce886c
Fix hide channel for search results
Shadorc 365bbe1
Fix hide channel for trending page
Shadorc 3357218
Fix hide channel for next recommended video
Shadorc 79c28f3
Fix exceptions when using Invidious API
Shadorc 8879a78
Code clean-up
Shadorc c3f23ca
Update to latest vesion of ytjs mr
Shadorc c9897bf
Code -clean-up
Shadorc 50c0437
Add possibility to hide/unhide channel from collab videos
Shadorc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
props.data.collaborators[0].id: Does that mean the first guy (XXXandYYY:XXX) or 2nd one (YYY`)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collaborators array always contains the original author as the first element
It's either (author is not a field, but you get the idea):
{ author: 'XXX', collaborators: [] }or
{ author: null, collaborators: ['XXX', 'YYY'...] }There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit weird that it will only block for the main author and not secondary collaborators.
Ex:
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why it is decided like this, but this behavior was described here #7871 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efb4f5ff-1298-471a-8973-3d47447115dc Any chance you remember the reason? I'm thinking it was the data not being available for the other channels but it looks like the data for the other channels is available now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could easily see people wanting to block content from e.g. MrBeast but would be interested to watch content where they are a collaborator in, especially in genres they arent publishing their content in themselves e.g. science, podcasts, business